Attention is currently required from: laforge, tnt, ttsou.
tempest has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/41231?usp=email )
Change subject: trx: Fix tx/rx-sps 4 for USRP1 devices
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
would someone be as kind as to address the linter complaints, this way we can get a V+1 for this pat […]
should I fix it as the linter is suggesting? The multi-line function call format it's complaining about is used a couple lines down (Line 126, https://gerrit.osmocom.org/c/osmo-trx/+/41231/1/Transceiver52M/device/usrp1/...) so I don't know if there's an issue with consistency
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/41231?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3b08c23a3e7d4a226cd23b9fe42558f596a63257
Gerrit-Change-Number: 41231
Gerrit-PatchSet: 1
Gerrit-Owner: tempest
jackleea1b@gmail.com
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: tnt
tnt@246tNt.com
Gerrit-Reviewer: ttsou
tom@tsou.cc
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: tnt
tnt@246tNt.com
Gerrit-Attention: ttsou
tom@tsou.cc
Gerrit-Comment-Date: Wed, 22 Oct 2025 16:22:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org