pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email )

Change subject: socket.h: Include netinet/in.h instead of arpa/inet.h ......................................................................

socket.h: Include netinet/in.h instead of arpa/inet.h

In socket.h we are mainly interested in netinet/int.h, since that's the one defining INET_ADDRSTRLEN, struct sockaddr_in, struct in_addr, ec.

Header arpa/inet.h usually defines several functions which use those, like htonl(), inet_ntop(), etc.

See POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/arpa_inet.h.html#t... https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netinet_in.h.html

Change-Id: I03919c4adc962bbcfabc9030c6f12c0e10ff060c --- M include/osmocom/core/socket.h 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved

diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h index e9979f5..845efd7 100644 --- a/include/osmocom/core/socket.h +++ b/include/osmocom/core/socket.h @@ -12,7 +12,7 @@ #include <stdbool.h> #include <stddef.h>

-#include <arpa/inet.h> +#include <netinet/in.h>

#include <osmocom/core/defs.h>