Attention is currently required from: fixeria, pespin.

csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 5:

(3 comments)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/48ad9705_e35f808a?usp=... : PS3, Line 1823: if (find_element

Acknowledged

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/6ba3b4f2_1c0d3d33?usp=... : PS3, Line 1825: get_object_identity_string(object_id_state[4]), object_id_state[5], get_object_state_string(object_id_state[10]));

Acknowledged

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/5dfb9a68_006f3756?usp=... : PS3, Line 1853: if (find_element

IN any case, what's the point in doing "if (foobar());" ? […]

Done

Digging more here revealed that object_id + object_state OR object_id_state are always present, and if you have object_id then there must be an object_state as well. And if none of this is present --> assert. The new solution reflects this.