Attention is currently required from: pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 )
Change subject: Use GSUP APN as Service-Selection field
......................................................................
Patch Set 1:
(1 comment)
File src/server_cb.erl:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514/comment/bc61008c_f...
PS1, Line 152: % 'Service-Selection' = "internet"%maps:get(access_point_name, GsupPdpInfo)
so now we have 2 levels of line-comments. […]
I hate when rebasing kills me :).
Good catch. This line shouldn't be commented out ;P
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab
Gerrit-Change-Number: 32514
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 26 Apr 2023 19:08:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment