Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31049 )

Change subject: llc: Initial support for GRR-UNITDATA.ind/req ......................................................................

Patch Set 1:

(17 comments)

File include/osmocom/gprs/llc/llc_prim.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/382c006e_6636ea62 PS1, Line 299: uint32_t tlli, uint8_t *ll_pdu, size_t ll_pdu_len); adding a line without newline at end of file

File src/llc/llc.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/770937bd_d18d7576 PS1, Line 787: } adding a line without newline at end of file

File tests/llc/llc_prim_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/4ad31288_a696880f PS1, Line 87: Length: 2 code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/b55caf84_391f3138 PS1, Line 88: 1... .... = GEA/1: Encryption algorithm available code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/c98a8954_871035fa PS1, Line 89: .1.. .... = SM capabilities via dedicated channels: Mobile station supports mobile terminated point to point SMS via dedicated signalling channels code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/a154d49f_9e6e0cda PS1, Line 90: ..1. .... = SM capabilities via GPRS channels: Mobile station supports mobile terminated point to point SMS via GPRS packet data channels code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/a893b721_661bfcd3 PS1, Line 91: ...0 .... = UCS2 support: The ME has a preference for the default alphabet (defined in 3GPP TS 23.038 [8b]) over UCS2 code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/0fcb2579_62c8bf0a PS1, Line 92: .... 01.. = SS Screening Indicator: capability of handling of ellipsis notation and phase 2 error handling (0x1) code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/617d00f8_f876519b PS1, Line 93: .... ..0. = SoLSA Capability: The ME does not support SoLSA code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/3fbf1b0f_222e5dc3 PS1, Line 94: .... ...1 = Revision level indicator: Used by a mobile station supporting R99 or later versions of the protocol code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/73c17de7_f565dd23 PS1, Line 95: 1... .... = PFC feature mode: Mobile station does support BSS packet flow procedures code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/532a7af9_fc8fca0b PS1, Line 96: .110 000. = Extended GEA bits: 0x30 code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/859b64c6_20e4c644 PS1, Line 97: .... ...0 = LCS VA capability: LCS value added location request notification capability not supported code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/555a7cb4_9d389ceb PS1, Line 105: Element ID: 0x17 code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/77e06273_725716a0 PS1, Line 106: GPRS Timer: 10 sec code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/3f84f92d_4b8e38d0 PS1, Line 107: 000. .... = Unit: value is incremented in multiples of 2 seconds (0) code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2945): https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/52db6309_de547dc1 PS1, Line 108: ...0 0101 = Timer value: 5 code indent should use tabs where possible