Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28712 ) Change subject: Refactor {cbsp,sbcap}_cbc_accept_cb ...................................................................... Patch Set 1: (2 comments) File src/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28712/comment/2d4b9c36_c630a80a PS1, Line 181: talloc_free(link); Don't we need to do: llist_del(&link->list); osmo_fsm_inst_free(link->fi); before talloc_free()? File src/sbcap_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28712/comment/c7c5a564_42769c67 PS1, Line 209: talloc_free(link); Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 Gerrit-Change-Number: 28712 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 17:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment