Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 )
Change subject: trxcon: Initial support for forwarding AMR ......................................................................
Patch Set 3:
(3 comments)
File src/host/trxcon/src/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/69326fb0_b3b366c2 PS3, Line 47: sched_tchf_dl_amr_cmi_map Cool! Would you submit a patch to osmo-bts.git adding this table there?
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/b2f119a8_5972d30c PS3, Line 48: [11] = 1, /* TCH/F: a=4 / h=11 */ Please fix the alignment, I find the old variant a bit easier to read.
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/15131430_ca972957 PS3, Line 56: ul_amr_fn_is_cmi This function can be replaced with sched_tchf_ul_amr_cmi_map[] from patchset 2.