Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email )
Change subject: stp: IPA: Introduce test TC_beat ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File stp/STP_Tests_IPA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472/comment/20403e21_4772a... : PS3, Line 495: var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; : v Not critical, but this is another place where additional variables could be avoided by passing `IPAC_MSGT_{PING,PONG}` straight to `enum2int()`. Looks like more lines of code for no reason. This may sound like nitpicking, but smaller/shorter functions are generally easier to read.
-
fixeria