Attention is currently required from: pespin.

Patch set 3:Code-Review +1

View Change

1 comment:

• File stp/STP_Tests_IPA.ttcn:

  • Patch Set #3, Line 495:

    	var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING;
    	v
    

    Not critical, but this is another place where additional variables could be avoided by passing `IPAC_MSGT_{PING,PONG}` straight to `enum2int()`. Looks like more lines of code for no reason. This may sound like nitpicking, but smaller/shorter functions are generally easier to read.

To view, visit change 40472. To unsubscribe, or for help writing mail filters, visit settings.