Attention is currently required from: csaba.sipos, laforge, pespin.

domi has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 22:

(2 comments)

Patchset:

PS22: Could you all please look at Patchset 22, I tried correcting everything. Please stop discussing Patchset 21, which is not the latest. If PS22 is OK let's move this, please please.

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/7273a6cc_f132e5cf?usp=... : PS21, Line 1860: !FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) {

Simple check all around the code shows it's 8 spaces per tab, please change your editor config and s […]

Could you all please look at Patchset 22, I tried correcting everything. Please stop discussing Patchset 21, which is not the latest. If PS22 is OK let's move this, please please.