Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email )
Change subject: docs: various osmux API documentation updates
......................................................................
Patch Set 3: Verified+1
(2 comments)
File include/osmocom/netif/osmux.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/2eb76c1b_1329abbd
PS3, Line 99: /*! return pointer to osmux payload (behind osmux_hdr */
missing ")"
Done
File src/osmux.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/3d76cf71_dbf1c803
PS3, Line 31: if (ret < 0) \
This should probably be moved to osmo_strbuf anyway.
maybe, but that's not part of this documentation patch.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117
Gerrit-Change-Number: 36299
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 13:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment