Attention is currently required from: falconia.

jolly has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )

Change subject: bring twjit into libosmo-netif ......................................................................

Patch Set 5:

(1 comment)

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/2bd3233b_02edda43... : PS5, Line 486: msgb_free(new_msg);

...

Is there a twjit instance for every payload type or one for the complete RTP connection? […]

It is ok for me to have a more specific de-jitter process, rather than something that solves all needs. I looked in my own de-jitter code and found the same. (drop sequence of frames with same time stamp) It makes sense, if only a voice stream (without telephone-events) are de-jittered.

I looked into your RTP patch. The received RTP frame are directly sent to the jitter buffer. I suggest to split it, so the application can decide which frames are sent to the jitter buffer and which are not. Also it could decide not to use a jitter buffer at all. (when just doing RTP forwarding)