Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27922 ) Change subject: contrib/jenkins.sh: check osmo_bts_has_feature use ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-bsc/+/27922/comment/5c752bcf_af373d8d PS2, Line 31: bts_features_wrong_use="$(grep -r -n 'osmo_bts_has_feature.*bts->model->features' | grep -v 'jenkins.sh')" || true I'm not sure the variable will always be called bts. maybe just '->model->features'? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47eef4978aaf9e20fc00a3ca029568671bd09d8d Gerrit-Change-Number: 27922 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 17:05:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment