Attention is currently required from: Hoernchen, laforge, pespin.

osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )

Change subject: octsim: initial commit ......................................................................

Patch Set 5:

(2 comments)

File octsim/OCTSIM_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/0b427f35_173c1... : PS4, Line 22: //USB_Device_Match mp_usb_dev_match := { vid_pid := { vid := '1d50'H, pid := '60e3'H} };

can this be dropped?

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/60ee2d75_b2800... : PS4, Line 74: //activate(as_Tguard);

would be great to have Tguard working from the first commit...

I took over the patches from Eric, but can't test them currently as I don't have access to an octsim-tester setup. In SYS#5489#note-20 I posted an idea of how to test it in jenkins.

I'll wait with making more (especially non-cosmetic) changes until I can actually run the tests and verify they still work as intended.