Change in osmo-ttcn3-hacks[master]: hnbap: Add tr_HNBAP_HNBRegisterReject - gerrit-log

23 Aug 2022


      Attention is currently required from: daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29197 )
Change subject: hnbap: Add tr_HNBAP_HNBRegisterReject
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File library/hnbap/HNBAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29197/comment/37edaef7_9427b... 
PS1, Line 149: omit
doesn't it maeke sense to use '*' in a receive template here? So we match a message with or without the optional IEs.  For ts_, omit makes more sense, IMHO.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29197
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ide006cac4fcdc062614f53fb95970feb51d63731
Gerrit-Change-Number: 29197
Gerrit-PatchSet: 1
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 23 Aug 2022 17:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment