Attention is currently required from: fixeria, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36452?usp=email )
Change subject: fix VLR evil twin on LU with unknown TMSI ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/d1718f8a_e55af610 PS1, Line 15: be discarded, for the benefit of the new one.
interesting, which way around is that? do we also drop the old one there?
Yes, definetly drop the old one. In osmo-pcu is even more complex because we first lookup by TBF, and then the assigned MS object, but sometimes the MS object has non-yet-known-imsi. So at some point, when figuring out the IMSI, we figure out we have a duplicated MS object and we need to move gained information from the previous MS object and then drop that MS object plus its related TBFs.