Attention is currently required from: laforge, osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email )

Change subject: sigtran: Make osmo_ss7_asp struct private ......................................................................

Patch Set 8:

(1 comment)

File src/ipa.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645/comment/c14fba7c_7841dd... : PS3, Line 50: #i

maybe it makes sense to do a follow-up commit that changes the header names, looks like that is prob […]

Since they are in the same directory as the source file, hence included with "" it already becomes clear it's a private header imho. I didn't "start" this trend here, I just followed what was already there (see for instance how I did include/osmocom/gprs/*/*_private.h instead in libosmo-gprs when I wrote most of it).

That being said, I have no strong opinion, so if you really think another option is better, I'm fine to easily move all headers at the end in a follow-up commit when this gets merged, as suggested by osmith.