neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40645?usp=email )

(

3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: vty: Get rid of unneeded iu_client vty config ......................................................................

vty: Get rid of unneeded iu_client vty config

Use of osmo-iuh's iu_client API was removed from osmo-msc long time ago (see c4628a3ad4d3c5f65782b152b771bf80357235d6), and its removal is also scheduled in osmo-sgsn.

Still, some small reference bits were still left. Remove them.

The VTY init functions being dropped basically set g_rab_assign_addr_enc, which doesn't really seem to be used at all, only place is that file for vty related stuff which has actually no use in osmo-msc. Other 2 are asn1c debugging related, which can also probably be dropped.

This completelly removes references to iu_client.h in osmo-msc.

Related: OS#5487 Change-Id: I9cf83f2255e1e9aa83f3139b88ea81b2f5b686c3 --- M src/libmsc/msc_vty.c 1 file changed, 0 insertions(+), 10 deletions(-)

Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 2b21f70..41cb0d4 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -43,10 +43,6 @@ #include <osmocom/vty/misc.h> #include <osmocom/vty/stats.h>

-#ifdef BUILD_IU -#include <osmocom/ranap/iu_client.h> -#endif - #include <osmocom/msc/vty.h> #include <osmocom/msc/gsm_data.h> #include <osmocom/msc/gsm_subscriber.h> @@ -815,9 +811,6 @@ }

mgcp_client_config_write(vty, " "); -#ifdef BUILD_IU - ranap_iu_vty_config_write(vty, " "); -#endif

neighbor_ident_vty_write(vty);

@@ -2125,9 +2118,6 @@ /* Deprecated: Old MGCP config without pooling support in MSC node: */ mgcp_client_vty_init(msc_network, MSC_NODE, msc_network->mgw.conf);

-#ifdef BUILD_IU - ranap_iu_vty_init(MSC_NODE, (enum ranap_nsap_addr_enc*)&msc_network->iu.rab_assign_addr_enc); -#endif sgs_vty_init(); smsc_vty_init(msc_network); asci_vty_init(msc_network);