Attention is currently required from: laforge, pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 )
Change subject: RLCMAC_CSN1_Types: Add release 6 additions to
PacketCellChangeNotification
......................................................................
Patch Set 4:
(5 comments)
File library/RLCMAC_CSN1_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/334b8a07_81b7…
PS1, Line 1030: variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence =
'1'B, utran_target_cell_presence = '0'B)"
Is this what you have in mind?
I think this is what Pau meant, yes. And I have a proposal:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33314
Feel free to squash this fixup into your patch if you agree with it.
File library/RLCMAC_CSN1_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/c06e0fe5_97fb…
PS2, Line 948: uint3_t bandwith optional,
> 'bandwith' may be misspelled - perhaps
'bandwidth'? […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/74b8b409_4eb7…
PS2, Line 951: variant (bandwith) "PRESENCE(bandwith_presence =
'1'B)"
> 'bandwith' may be misspelled - perhaps
'bandwidth'? […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/7965514e_6d0a…
PS2, Line 956: uint3_t bandwith optional,
> 'bandwith' may be misspelled - perhaps
'bandwidth'? […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/3b025da9_792f…
PS2, Line 960: variant (bandwith) "PRESENCE(bandwith_presence =
'1'B)"
> 'bandwith' may be misspelled - perhaps
'bandwidth'? […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4
Gerrit-Change-Number: 32995
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 12:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment