Change in osmo-bsc[master]: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack - gerrit-log

28 Feb 2022


      Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27309 )
Change subject: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/osmo_bsc_bssap.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27309/comment/11b6dece_51e36a43 
PS1, Line 1449: return HO_RESULT_ERROR
...
Everywhere in this function I see -ERRNO returned, but here you return a positive integer from 'enum […]
yikes! good catch!
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1d0b395c97145b5aa1af4ef67aec9338d2f8f43b
Gerrit-Change-Number: 27309
Gerrit-PatchSet: 1
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 28 Feb 2022 10:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment