laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29993 )

Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ......................................................................

Support building with -Werror=strict-prototypes / -Werror=old-style-definition

Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99.

See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion.

Change-Id: Ied224520b9a09743bd19818ab00cbdf915baef34 --- M tests/jibuf/jibuf_test.c M tests/jibuf/jibuf_tool.c 2 files changed, 6 insertions(+), 6 deletions(-)

Approvals: laforge: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve

diff --git a/tests/jibuf/jibuf_test.c b/tests/jibuf/jibuf_test.c index e1f51d6..7643797 100644 --- a/tests/jibuf/jibuf_test.c +++ b/tests/jibuf/jibuf_test.c @@ -622,7 +622,7 @@ /* This test aims at testing scenarios described in OS#3262, in which syncpoint packets can provoke a situation in which packets are stored out-of-order in the queue. */ -static void test_rtp_marker_queue_order() +static void test_rtp_marker_queue_order(void) { int min_delay = 60; struct msgb *msg; diff --git a/tests/jibuf/jibuf_tool.c b/tests/jibuf/jibuf_tool.c index b69686a..0502a98 100644 --- a/tests/jibuf/jibuf_tool.c +++ b/tests/jibuf/jibuf_tool.c @@ -336,7 +336,7 @@ return cb->data; }

-void rand_send_rtp_packet() +void rand_send_rtp_packet(void) {

struct rtp_pkt_info *pinfo; @@ -458,7 +458,7 @@ } }

-void rand_test_check() +void rand_test_check(void) { uint32_t drop_threshold = NUM_PACKETS_TO_SEND * 5 / 100; if (packets_dropped > drop_threshold) { @@ -475,7 +475,7 @@ } }

-void rand_test() +void rand_test(void) { srandom(time(NULL)); rtp_first_seq = (uint16_t) random(); @@ -503,11 +503,11 @@ rand_test_check(); }

-void pcap_test_check() { +void pcap_test_check(void) {

}

-void pcap_test() { +void pcap_test(void) { osmo_pcap_init();

osmo_pcap.h = osmo_pcap_test_open(opt_pcap_file);