Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 )

Change subject: Refactor subscr_conn_get_next_id ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/osmo-bsc-nat/subscr_conn.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711/comment/40e35b2a_478ab827 PS2, Line 31: { I think it makes much more sense to have 3 separate functions, other than having a 1 more complex function with a more complex lookup loop, which can potentially iterate 2^32 times.