Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28168 )
Change subject: ggsn: TC_act_deact_retrans_duplicate: Fix case where initial seq_nr is
65535
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28168/comment/ff99b93f_eeda…
PS1, Line 7: 65535
You meant 0?
No, I meant what I said. When the
initial seq_nr was 65535, it is then incremented by the function sending it. So when we
check, the value is already incremented, that's why we check against 0.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28168
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2a7a399cf962311aaf7270260cb2e4e00e5a676a
Gerrit-Change-Number: 28168
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 19 May 2022 20:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment