Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31179 ) Change subject: rest_api: strtoul canot return negative ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/server/rest_api.c: https://gerrit.osmocom.org/c/osmo-remsim/+/31179/comment/5c584f85_4d41f223 PS1, Line 413: if (map_id == ULONG_MAX) { man strtoul: """ Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for strtoull()) on both success and failure, the calling program should set errno to 0 before the call, and then determine if an error occurred by checking whether errno has a nonzero value after the call. """ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic5019e216dd7b26be0bd988df218a2cb5775e411 Gerrit-Change-Number: 31179 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 06 Feb 2023 07:32:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment