Attention is currently required from: fixeria, osmith, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )
Change subject: ss7 vty: Fix insert order of routes with higher priority
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Patchset:
PS5:
s
File tests/vty/osmo_stp_route_prio.vty:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/62aa3755_b32f76... :
PS2, Line 87: 3.2.1/14 0 as3 ? ? ?
I'll be changing default prio to 5 in a follow-up patch.
I agree, we should also use 5 as default. Also, the value range is (should be?) constrained to 0-10 AFAIR, so the > 16bit values you suggested above are not a good idea anyway.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218
Gerrit-Change-Number: 38375
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de