pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email ) Change subject: sua: sua_iei_names: s/Cause/SCCP Cause/ ...................................................................... sua: sua_iei_names: s/Cause/SCCP Cause/ This is how the field is named in RFC 3868 section 3.10. This also helps identifying it from other existing field "User/Cause". Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 --- M src/sua.c M tests/xua/xua_test.ok 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/sua.c b/src/sua.c index 3d9d7ec..2753cfe 100644 --- a/src/sua.c +++ b/src/sua.c @@ -89,7 +89,7 @@ { SUA_IEI_DEST_ADDR, "Destination Address" }, { SUA_IEI_SRC_REF, "Source Reference" }, { SUA_IEI_DEST_REF, "Destination Reference" }, - { SUA_IEI_CAUSE, "Cause" }, + { SUA_IEI_CAUSE, "SCCP Cause" }, { SUA_IEI_SEQ_NR, "Sequence Number" }, { SUA_IEI_RX_SEQ_NR, "Receive Sequence Number" }, { SUA_IEI_ASP_CAPA, "ASP Capability" }, diff --git a/tests/xua/xua_test.ok b/tests/xua/xua_test.ok index 3072a95..9d44775 100644 --- a/tests/xua/xua_test.ok +++ b/tests/xua/xua_test.ok @@ -75,7 +75,7 @@ => BSSMAP-RELEASED SCCP Input: [L2]> 04 00 00 03 01 02 03 00 01 0f 02 23 42 00 Transcoding message SCCP -> XUA -Decoded SUA: HDR=(CO:RELRE,V=0,LEN=0), PART(T=Destination Reference,L=4,D=00000003), PART(T=Source Reference,L=4,D=00010203), PART(T=Cause,L=4,D=00000300), PART(T=Data,L=2,D=2342) +Decoded SUA: HDR=(CO:RELRE,V=0,LEN=0), PART(T=Destination Reference,L=4,D=00000003), PART(T=Source Reference,L=4,D=00010203), PART(T=SCCP Cause,L=4,D=00000300), PART(T=Data,L=2,D=2342) Re-Encoding decoded SUA to SCCP SCCP Output: [L2]> 04 00 00 03 01 02 03 00 01 0f 02 23 42 00 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 Gerrit-Change-Number: 38548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>