Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685?usp=email ) Change subject: vty: Introduce cmd 'cs7 instance <0-15> asp NAME audit point-code POINT_CODE' ...................................................................... Patch Set 2: (4 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/aa032dbb_ba77f… : PS2, Line 10: when response arrive : in case we run under some sort of misalignment with peer. I find this part of the statement hard to read/understand. Could you rephrase please? What response? The response to DAUD? Maybe "... to manually update the local state in situations when the (what?) response arrives during some sort of misalignment with the peer"? File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/48a553e2_6bf47… : PS2, Line 110: osmo_ss7_pointcode_print_buf Why not using `osmo_ss7_pointcode_print()` here? Does not seem like you have to use a local buffer here... https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/1f75d70b_087e4… : PS2, Line 118: audit point-code Are you planning to add more commands related to `audit`? If not, maybe make it a single term like `audit-point-code` or `audit-pc`? https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/1eb0326d_899d9… : PS2, Line 132: vty_out cosmetic: here and below: missing `%%` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I607df3d84562e56d329bea1a730e26c8cdaae591 Gerrit-Change-Number: 40685 Gerrit-PatchSet: 2 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 15 Jul 2025 18:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No