Attention is currently required from: laforge, lynxis lazus.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34884?usp=email )
Change subject: pySim-shell: don't get trapped in applications without file system
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/34884/comment/bfa9df8b_7c051cdc
PS2, Line 620: "a0000000871002", "a0000000871004"]:
I have now changed the code so that it does no longer use the hardcoded identifiers. Also not "ADF. […]
With the help of the fixed selected_adf and the new has_fs flag in the ADF classes (see patches before this one) I managed to get a generic solution.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34884?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia2fdd65f430c07acb1afdaf265d24c6928b654e0
Gerrit-Change-Number: 34884
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 26 Oct 2023 09:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment