Attention is currently required from: daniel, jolly, pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36062?usp=email )

Change subject: osmo_io: Change struct osmo_io_ops to contain struct, not union ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS1:

I think I already provided my opinion on this previously, I see no need to change it to struct, but […]

I would say over half of the problems in this patchset I saw the last few days were related to this being a union. Now those have been resolved, but I see potential for more of those problems in the future. So better be safe than to optimize for 4-5 * sizeof(unsigned long). If we really need to conserve memory, struct osmo_io_fd should simply point to the io_ops, rather than copying it into each and every osmo_fd.