Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. (
https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email )
Change subject: gen_makefile: --targets: fix subdir projects
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File gen_makefile.py:
https://gerrit.osmocom.org/c/osmo-dev/+/40978/comment/b89d12e5_764eb93a?usp… :
PS1, Line 247: if "_" in project:
No, because this doesn't change `project` and
because it checks if the resulting splitted string is […]
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8
Gerrit-Change-Number: 40978
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Sep 2025 07:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>