Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email )
Change subject: drivers/dahdi: fix always true cond
......................................................................
Patch Set 1:
(1 comment)
File drivers/dahdi/xpp/xbus-core.c:
https://gerrit.osmocom.org/c/dahdi-linux/+/39593/comment/d58f461a_131ca2a3?u... :
PS1, Line 116: if (xbus->label) {
are you sure about this one? Looks like you are removing a check againstbeing len(xbus->label)>0 here.
--
To view, visit
https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806
Gerrit-Change-Number: 39593
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Comment-Date: Thu, 20 Feb 2025 13:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No