neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37681?usp=email )

Change subject: drop config.vty tests from make check ......................................................................

drop config.vty tests from make check

The intention of those tests was to test various osmo-hnbgw startup scenarios. It seemed the fastest/simplest way to do it at the time, but the output depends on another library, regularly causing test fallout.

Keep the tests around for reference. They can still be invoked manually with 'make config-tests'.

Related: OS#6380 Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b --- M tests/Makefile.am 1 file changed, 22 insertions(+), 1 deletion(-)

Approvals: Jenkins Builder: Verified neels: Looks good to me, approved

diff --git a/tests/Makefile.am b/tests/Makefile.am index a4dcf4c..257c0bf 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -43,7 +43,6 @@ if ENABLE_EXT_TESTS python-tests: $(MAKE) vty-test - $(MAKE) config-tests osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else @@ -69,6 +68,11 @@ $(U) $(srcdir)/$(VTY_TEST)

# Test each config/*.cfg file with the corresponding config/*.vty transcript test. +# +# To be invoked manually only: This is not part of 'make check' because the +# output may change when libosmo-sccp changes its VTY appearance, which can +# cause annoying test fallout. +# # Each config test runs an osmo-hnbgw process to talk to, so they must not run concurrently. # To prevent 'make -j N' from running these tests in parallel, call a script with a linear for-loop. .PHONY: config-tests