Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email )

Change subject: s1gw: add TC_pfcp_heartbeat ......................................................................

Patch Set 3:

(2 comments)

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037/comment/1f816126_a15ef... : PS2, Line 330: rts := f_pfcp_get_recovery_timestamp();

See my comment from last patch, you are also getting the value here, so you could have passed it to […]

Ack, I'll address this in the next patchset revision.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037/comment/cb350cc2_deb9c... : PS2, Line 336: f_ConnHdlr_pfcp_expect(tr_PFCP_Heartbeat_Resp);

(this function should probably return the actually received value matching the template. […]

It already does.