Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35783?usp=email )
Change subject: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM
......................................................................
Patch Set 1:
(1 comment)
File src/rlcmac/tbf_ul.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/35783/comment/70e5a476_80dc24b1
PS1, Line 338: ev_ack
why not passing `struct gprs_rlcmac_dl_block_ind *` directly? […]
You never know, and the struct is already there, so no harm in leaving it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/35783?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Iaa8ad8052b9f3b52b05af2b7fc9cb8172f1b6bb7
Gerrit-Change-Number: 35783
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 02 Feb 2024 22:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment