Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428 ) Change subject: sgsn: add TC_iu_attach_encr with UEA > 0 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428/comment/22a64663_1c1d… PS1, Line 691: private function f_mm_ciph_utran() runs on BSSGP_ConnHdlr This looks more like an altstep to me rather than a function. If you turn it into an altstep, we would be able to use it in 'alt' statements later. At the same time, you would still be able to execute it like a function. Not a merge blocker though. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428/comment/6616d71c_5c67… PS1, Line 691: mm It should be '_gmm_' in the context of GPRS. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a7c3b156830058c43f15f55883ea301d2d01d5f Gerrit-Change-Number: 27428 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 13:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment