falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36967?usp=email )
Change subject: gsm48_ie: add helper function for speech bearer cap on GSM MS side ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: @laforge@osmocom.org wrote:
I'm not entirely sure if this should go into the library or into osmocom-bb, though.
If osmocom-bb devs (of which I am obviously not one) feel that this code should go there, please feel free to lift the code from this patch and adapt as you see fit. I can't be the patch owner on anything going into osmocom-bb repo (outside of rare exceptions of which this isn't one), but please feel free to reuse the code itself as you like.
The only reason I produced this patch is because it would have been improper to argue against the other patch (by @degrunert.web@googlemail.com) without offering an alternative - but it is absolutely **not** my place to argue or even suggest what osmocom-bb should or should not do.
As food for thought though, whoever takes this issue up in osmocom-bb will have to decide how to handle the "policy" aspect of it, i.e., selecting between spec-correct behavior vs sending intentionally invalid stuff like in that Russian MNO experiment that brought this whole issue into focus.