[M] Change in osmo-bsc[master]: simplify storage of bsc_msc_data->audio_support - gerrit-log

2 Mar 2023


      Attention is currently required from: laforge, pespin, fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31609 )
Change subject: simplify storage of bsc_msc_data->audio_support
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/bsc/bsc_msc_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31609/comment/16800c4e_1954c397 
PS1, Line 140: 	struct gsm_audio_support audio_support[16];
...
Well my point is that if there's only up to 13, I don't see why we want to lose memory there declari […]
you're right. i thought my compiler would say "size_t" explicitly, but apparently it says 'long unsigned int' for size_t arguments, maybe that changed.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I625cedc4bb040d649fd6e1794ba468f4c6ad6adc
Gerrit-Change-Number: 31609
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 02 Mar 2023 16:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment