[M] Change in osmo-ttcn3-hacks[master]: hnbgw: prepare cn pool: add multiple MSCs and SGSNs - gerrit-log

4 Jul 2023


      Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480 )
Change subject: hnbgw: prepare cn pool: add multiple MSCs and SGSNs
......................................................................
Patch Set 2: -Code-Review
(2 comments)
Patchset:
PS2: 
Is there really a benefit in having both SGSNs and MSCs mixed in the same array and then having to use to use offsets depending on the type? Doesn't look like to me.
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480/comment/66a8297a_7602d... 
PS2, Line 261: 	/* array index in g_cn[] (in which SGSNs follow MSCs) */
I don't really understand this comment.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33480
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia29565cabc072de9aa46565b57232e1eda65874f
Gerrit-Change-Number: 33480
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Tue, 04 Jul 2023 09:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment