Attention is currently required from: laforge, pespin, fixeria.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 )
Change subject: codec: add SID classification functions per GSM 06.31 & 06.81
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/codec/codec.h:
https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/cbb92864_83545425
PS1, Line 85: etsi_sid_class
pespin is correct in that they predate our naming conventions. […]
In the new patchset the enum is named osmo_gsm631_sid_class and its items are prefixed with OSMO_GSM631_.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32183
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916
Gerrit-Change-Number: 32183
Gerrit-PatchSet: 3
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sun, 16 Apr 2023 02:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment