Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39364?usp=email ) Change subject: coverity: vty for AMR start mode: clarify range checks ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39364/comment/5b31a029_1a951a15?usp… : PS1, Line 2785: for (int i = 0; i < ((full) ? 8 : 6); i++) { afaiu "i" can also be unsigned? which would be saner since it's only used to shift. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34ac83e1441a34fcec6b10c34e10ab6dffa37607 Gerrit-Change-Number: 39364 Gerrit-PatchSet: 1 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 17 Jan 2025 13:23:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes