Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28596 )
Change subject: fixed out of bounds write to pdu_sync buffer ......................................................................
Patch Set 1:
(1 comment)
File src/conv_enc_test.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/28596/comment/5c2f0aab_8a8a415f PS1, Line 338: *((uint32_t *)pdu_sync) = r; are we sure pdu_sync is always aligned and the type-cast is safe even on architectures that don't do unaligned accesses? we do have osmo_store{32,64}{le,be}() in osmocom/core/bit{32,64}gen.h