Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34340?usp=email )
Change subject: bts-trx: Fix CCCH not enabled if BS_AG_BLKS_RES!=1 is provided by BSC
......................................................................
Patch Set 1:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/34340/comment/a15f7222_93f00162
PS1, Line 635: lchan_deactivate
I am wondering why can't we call
`lchan_activate(lchan)` right after calling `lchan_deactivate(lchan […]
yes,
it's async, see the comment below I added.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/34340?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61e1681fbaa2c993b529d58b581c99166b62bda3
Gerrit-Change-Number: 34340
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Sep 2023 21:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment