Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )

Change subject: Make esme struct shared ......................................................................

Patch Set 20:

(2 comments)

File include/osmocom/smpp/smpp.h:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/a92f05af_e8da2e61 PS19, Line 14: struct esme {

prefer 'struct smpp_esme' since it is from smpp. […]

does that mean you disagree here?

File include/osmocom/smpp/smpp_smsc.h:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b06a9b74_d636e9bd PS19, Line 32: struct esme *esme;

Hi Neels, it's fine the way the patch is now, I actually pointed towards the current directon, since […]

there is a point at which hiding struct details is more of a hindrance than helping. When a struct is not public API of a library, IMHO it is better to openly share the structs than using opaque structs with tons of functions for every struct access, and dynamic allocations that cannot be optimized by the compiler.