Change in osmo-ttcn3-hacks[master]: BSC: add TC_ho_meas_rep_multi_band - gerrit-log

25 Oct 2022


      Attention is currently required from: osmith, neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 )
Change subject: BSC: add TC_ho_meas_rep_multi_band
......................................................................
Patch Set 3:
(1 comment)
File library/BSSMAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/854f4d89_befa4... 
PS3, Line 898: cid_list := *
...
Wouldn't this break existing code using this?
No, it would not. This template modifies 'tr_BSSAP_BSSMAP', which does set 'pdu.bssmap' (and thus all inner firelds) to '?'. PDU_BSSMAP_HandoverRequired.cellIdentifierList is always expected to be present. Before your change the implicit default value is '?'. Value '*' makes no sense because it can never be 'omit'. Adding '(present)' template restriction explicitly tells the caller that it's always present and cannot be 'omit'.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286
Gerrit-Change-Number: 29837
Gerrit-PatchSet: 3
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Tue, 25 Oct 2022 16:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment