Attention is currently required from: laforge, osmith.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email )

Change subject: soft_uart: implement modem status lines and flow control ......................................................................

Patch Set 3:

(1 comment)

File src/core/soft_uart.c:

https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/175e3003_05fc6ccf PS2, Line 398: if (active) /* assert the given line */

This might be just me, but I always associate assert with assert(), as in crash the program here if […]

Hmm, I see your point. But this is the terminology used in mostly all documentation I read so far, for instance "The signal is asserted (logic '1') by raising the voltage of the pin from negative to positive". Let's see what the others think.