Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27390 ) Change subject: mgcp_network: fix typo ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/27390/comment/cf5410cb_cc0e99a8 PS1, Line 1533: /* If AMR is configured for the ingress connection a conversion of the This line is also difficult to read. I'd rewrite the entire phrase as: """ If AMR is configured for the ingress connection, then a conversion of the framing mode (octet-aligned vs. bandwith-efficient) is explicitly defined, so we check if the incoming payload matches that expectation. """ https://gerrit.osmocom.org/c/osmo-mgw/+/27390/comment/b943de60_957267c5 PS1, Line 1534: * framing mode (octet-aligned vs. bandwith-efficient is explicitly I think there's a ")" missing here too, can you fix it while at it? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I23f6672338b26eb74f6d3a753a3863e02af24ae0 Gerrit-Change-Number: 27390 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 14:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment