Attention is currently required from: osmith, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/16145 )
Change subject: logging: get rid of logging category DSUM
......................................................................
Patch Set 3:
(5 comments)
This change is ready for review.
Patchset:
PS3:
I wonder if we can completely remove that category.
Agree, removed in the new patchset.
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/16145/comment/d885e0fb_6beebce5
PS1, Line 309: LOGP(DBTS, LOGL_INFO, "Main link established, sending
Status'.\n");
Could be oml
Done
https://gerrit.osmocom.org/c/osmo-bts/+/16145/comment/2fc0d35d_ecc7dbf1
PS1, Line 345: LOGP(DBTS, LOGL_INFO, "RSL link (TRX %02x) state changed to %s,
sending Status'.\n",
Could be rsl
Done
https://gerrit.osmocom.org/c/osmo-bts/+/16145/comment/1bd5d075_c0616413
PS1, Line 369: LOGP(DBTS, LOGL_INFO, "TRX(%d): Setting available = %d\n",
OML too
Done
https://gerrit.osmocom.org/c/osmo-bts/+/16145/comment/c3bc06ef_8b6ba0cc
PS1, Line 635: LOGP(DBTS, LOGL_ERROR,
RR?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/16145
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia9db783bc92b23ba87b4fdf1e4ed07d59ea6bbce
Gerrit-Change-Number: 16145
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Feb 2022 08:33:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment