Attention is currently required from: daniel, lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email )
Change subject: Refactor diffing same GMM messages ......................................................................
Patch Set 15:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/be19f081_f61eaf54?usp... : PS15, Line 9: isn'nt typo: isn't
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/885cad83_f2335cd8?usp... : PS15, Line 1432: Checks if two attach request contain the IEs and IE values This needs to be updated.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/2fa1e281_be90b6eb?usp... : PS15, Line 1435: return 1/-1 following memcmp() This is not true. From `man memcmp`:
``` The memcmp() function returns an integer less than, equal to, or greater than zero ... ```
Now it's a positive or negative integer on mismatch.
-
fixeria