Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email )

Change subject: vlr: use correct types for vlr_timer ......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/38356/comment/2c71c821_e9f7dbdd?usp=... : PS1, Line 9: an integer

(It's not critical, not blocking), but I was a bit confused reading this before I looked at the actu […]

Done

File include/osmocom/vlr/vlr.h:

https://gerrit.osmocom.org/c/osmo-msc/+/38356/comment/343fce67_0f61eb51?usp=... : PS1, Line 427: unsigned long vlr_timer(struct vlr_instance *vlr, int timer);

so the point here is that this function actually returns the timer value right? Can we please rename […]

Sometime I find it hard fixing one thing and getting such review of, please fix also this thing, while you're at it.