Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )
Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ......................................................................
Patch Set 9:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39741/comment/312057c6_a67bea8f?usp=ema... : PS9, Line 37: class ConfigurableParameter:
why is the new ConfugirableParameter not an ABC anymore? Can it be used directly, without further in […]
I do not understand what ABC is for; this is an educated "i do not understand" as in, i have yet to be explained what class of problem is solved by it. Why do i not see ABC anywhere in, for example, Django's abstract classes, or in any other python library code i read.
The abstract concept that I need could not be satisfied by ABC, i did test it. Instead, i introduce an explicit is_abstract flag in I4970657294130b6b65d50ff19ffbb9ebab3be609 -- i'm pushing more of the branch now so the patch is visible here on gerrit as well.
I feel that i have reasoned this before, would welcome some trust in my judgement...? Otherwise we should schedule a call because this is circling too often.
In my POV this is one tiny very early meaningless patch in a large series that I feel makes a lot of sense as a whole, and it is only split as it is here because i spent a lot of time on not submitting a code bomb. Hence you don't see the end result, and we get stuck in language evangelism... maybe a code bomb would be better in this instance?